Feedback for shiny-javascript.Rmd #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 9.1 Shiny JavaScript sources: I would want to see a image of the Github project page to complement the first paragraph. It is hard to understand the folder structure you are talking about in the paragraph.
2. Figures 9.1, 9.2, and on: Somewhat hard to read the text. Can you make the image zoomable? That way, readers can click on the image and see an enlarged view.
3. Figure 9.3: I downloaded VS code from scratch and tried to run the code. However, I couldn't find the "run arrow" as seen in the Figure. I don't think the "run arrow" is there by default? Maybe if you could include a section on how to run code on VS Code, that'd be helpful for beginners.
4. The sentence below 9.4.4.2 Strings ("Below are the main methods related to the String object (character in R).") is vague. What do you mean inside the parenthesis?
|
vscode would deserve a better attention. I am not sure however if I will have time. Other reviewers suggested to drop it. |
DivadNojnarg
force-pushed
the
master
branch
4 times, most recently
from
ce08e8d
to
48262ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9.1 Shiny JavaScript sources: I would want to see a image of the Github project page to complement the first paragraph. It is hard to understand the folder structure you are talking about in the paragraph.
Figures 9.1, 9.2, and on: Somewhat hard to read the text. Can you make the image zoomable? That way, readers can click on the image and see an enlarged view.
Figure 9.3: I downloaded VS code from scratch and tried to run the code. However, I couldn't find the "run arrow" as seen in the Figure. I don't think the "run arrow" is there by default? Maybe if you could include a section on how to run code on VS Code, that'd be helpful for beginners.
The sentence below 9.4.4.2 Strings ("Below are the main methods related to the String object (character in R).") is vague. What do you mean inside the parenthesis?