Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tools): Switch to ruff for import sorting. #1168

Merged
merged 11 commits into from
Mar 29, 2024

Conversation

elenakrittik
Copy link
Contributor

Summary

Replaces isort with ruff's I rule group. This caused only two changes, and both were correct. Also updates ruff to 0.3.3.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: meta Changes to the project itself (CI, configs, etc.) skip news labels Mar 19, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Mar 19, 2024
@elenakrittik elenakrittik marked this pull request as ready for review March 19, 2024 15:34
@shiftinv shiftinv added the t: refactor/typing/lint Refactors, typing changes and/or linting changes label Mar 19, 2024
disnake/embeds.py Outdated Show resolved Hide resolved
examples/ruff.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
examples/interactions/injections.py Outdated Show resolved Hide resolved
examples/ruff.toml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!
The whole project root thing still feels a bit weird, but going off of the FAQ this seems like the intended solution.

@shiftinv shiftinv enabled auto-merge (squash) March 29, 2024 12:14
@shiftinv shiftinv merged commit 2919c61 into DisnakeDev:master Mar 29, 2024
28 checks passed
@elenakrittik elenakrittik deleted the deps/update-ruff branch March 29, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews skip news t: meta Changes to the project itself (CI, configs, etc.) t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants