-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tools): Switch to ruff for import sorting. #1168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftinv
added
s: needs review
Issue/PR is awaiting reviews
t: meta
Changes to the project itself (CI, configs, etc.)
skip news
labels
Mar 19, 2024
8 tasks
shiftinv
added
the
t: refactor/typing/lint
Refactors, typing changes and/or linting changes
label
Mar 19, 2024
elenakrittik
force-pushed
the
deps/update-ruff
branch
from
March 19, 2024 16:35
c47aa6e
to
c007709
Compare
shiftinv
reviewed
Mar 26, 2024
Co-authored-by: shiftinv <[email protected]> Signed-off-by: lena <[email protected]>
… "temporary disables".
…snake into deps/update-ruff
shiftinv
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
The whole project root thing still feels a bit weird, but going off of the FAQ this seems like the intended solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
s: needs review
Issue/PR is awaiting reviews
skip news
t: meta
Changes to the project itself (CI, configs, etc.)
t: refactor/typing/lint
Refactors, typing changes and/or linting changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces isort with ruff's
I
rule group. This caused only two changes, and both were correct. Also updates ruff to 0.3.3.Checklist
pdm lint
pdm pyright