fix(typing): support Object category in create_x_channel (#1163)

changelog/1050.feature.rst

@@ -1,7 +1,7 @@
-- Add support for media channels.
-    - Add :class:`MediaChannel`.
-        - Unless otherwise noted, media channels behave just like forum channels.
-    - Add :attr:`ChannelType.media`.
-    - Add :attr:`CategoryChannel.media_channels`, :attr:`Guild.media_channels`.
-    - Add :attr:`CategoryChannel.create_media_channel`, :attr:`Guild.create_media_channel`.
-    - Add :attr:`ChannelFlags.hide_media_download_options`.
+Add support for media channels.
+- Add :class:`MediaChannel`.
+    - Unless otherwise noted, media channels behave just like forum channels.
+- Add :attr:`ChannelType.media`.
+- Add :attr:`CategoryChannel.media_channels`, :attr:`Guild.media_channels`.
+- Add :attr:`CategoryChannel.create_media_channel`, :attr:`Guild.create_media_channel`.
+- Add :attr:`ChannelFlags.hide_media_download_options`.

changelog/1162.bugfix.rst

@@ -0,0 +1 @@
+Adjust type annotations to allow :class:`Object` as ``category`` parameter in :meth:`Guild.create_text_channel` and similar methods.

disnake/guild.py

@@ -1234,7 +1234,7 @@ async def create_text_channel(
         name: str,
         *,
         reason: Optional[str] = None,
-        category: Optional[CategoryChannel] = None,
+        category: Optional[Snowflake] = None,
         position: int = MISSING,
         topic: Optional[str] = MISSING,
         slowmode_delay: int = MISSING,
@@ -1292,7 +1292,7 @@ async def create_text_channel(
             A :class:`dict` of target (either a role or a member) to
             :class:`PermissionOverwrite` to apply upon creation of a channel.
             Useful for creating secret channels.
-        category: Optional[:class:`CategoryChannel`]
+        category: Optional[:class:`abc.Snowflake`]
             The category to place the newly created channel under.
             The permissions will be automatically synced to category if no
             overwrites are provided.
@@ -1388,7 +1388,7 @@ async def create_voice_channel(
         self,
         name: str,
         *,
-        category: Optional[CategoryChannel] = None,
+        category: Optional[Snowflake] = None,
         position: int = MISSING,
         bitrate: int = MISSING,
         user_limit: int = MISSING,
@@ -1414,7 +1414,7 @@ async def create_voice_channel(
             A :class:`dict` of target (either a role or a member) to
             :class:`PermissionOverwrite` to apply upon creation of a channel.
             Useful for creating secret channels.
-        category: Optional[:class:`CategoryChannel`]
+        category: Optional[:class:`abc.Snowflake`]
             The category to place the newly created channel under.
             The permissions will be automatically synced to category if no
             overwrites are provided.
@@ -1512,7 +1512,7 @@ async def create_stage_channel(
         rtc_region: Optional[Union[str, VoiceRegion]] = MISSING,
         video_quality_mode: VideoQualityMode = MISSING,
         overwrites: Dict[Union[Role, Member], PermissionOverwrite] = MISSING,
-        category: Optional[CategoryChannel] = None,
+        category: Optional[Snowflake] = None,
         nsfw: bool = MISSING,
         slowmode_delay: int = MISSING,
         reason: Optional[str] = None,
@@ -1540,7 +1540,7 @@ async def create_stage_channel(
             A :class:`dict` of target (either a role or a member) to
             :class:`PermissionOverwrite` to apply upon creation of a channel.
             Useful for creating secret channels.
-        category: Optional[:class:`CategoryChannel`]
+        category: Optional[:class:`abc.Snowflake`]
             The category to place the newly created channel under.
             The permissions will be automatically synced to category if no
             overwrites are provided.
@@ -1633,7 +1633,7 @@ async def create_forum_channel(
         name: str,
         *,
         topic: Optional[str] = None,
-        category: Optional[CategoryChannel] = None,
+        category: Optional[Snowflake] = None,
         position: int = MISSING,
         slowmode_delay: int = MISSING,
         default_thread_slowmode_delay: int = MISSING,
@@ -1661,7 +1661,7 @@ async def create_forum_channel(
             The channel's name.
         topic: Optional[:class:`str`]
             The channel's topic.
-        category: Optional[:class:`CategoryChannel`]
+        category: Optional[:class:`abc.Snowflake`]
             The category to place the newly created channel under.
             The permissions will be automatically synced to category if no
             overwrites are provided.
@@ -1783,7 +1783,7 @@ async def create_media_channel(
         name: str,
         *,
         topic: Optional[str] = None,
-        category: Optional[CategoryChannel] = None,
+        category: Optional[Snowflake] = None,
         position: int = MISSING,
         slowmode_delay: int = MISSING,
         default_thread_slowmode_delay: int = MISSING,
@@ -1807,7 +1807,7 @@ async def create_media_channel(
             The channel's name.
         topic: Optional[:class:`str`]
             The channel's topic.
-        category: Optional[:class:`CategoryChannel`]
+        category: Optional[:class:`abc.Snowflake`]
             The category to place the newly created channel under.
             The permissions will be automatically synced to category if no
             overwrites are provided.