-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for the pesde package manager #26
base: refactor/monorepository-origin
Are you sure you want to change the base?
feat: add support for the pesde package manager #26
Conversation
also I know I just made a I'll be adopting versioned code soon after this as otherwise i'm going to be causing myself crazy headaches trying to do things on the fly.. |
CI is now failing with error: pls also review the pipeline, I'm guessing that what we're currently doing is shambles because we're using rokit, that reads from aftman.toml.. but we want to drop all of that anyway to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other nitpicks / misc changes I would suggest:
- Using a proper async primitive as discussed on Discord; Future along with a yielding variant of the package makes the most sense
- Add a pinned
pesde_version
field to all manifests, since pesde will have breaking changes and we want to prevent confusion among contributors; see pesde docs - Fix missing manifest metadata for some packages
- Get rid of type patching hack once Support Luau types when bundling seaofvoices/darklua#144 is implemented
- Symlink top-level license into packages, mark the license field, and include a copy of the symlinked license in the
includes
field of all packages to comply with MIT - Draft proper READMEs for individual packages
-
Rename packages, they are currently ambiguous (discordluau/classes is a prime example, what are they classes of? it is hard for a spectator to tell)- there's also discordluau/core which is confusing as raised by the initial comment
- For an initial publish, we should probably start versioning from v0.0.1 for some packages (mostly all the non-util ones)
- Can we call all the requires aliased as utilities as util instead? It is currently unnecessarily verbose
- Should improve wording of package descriptions
- Noticed a
bundled.luau
exception in the top-level.gitignore
, and from what I see, only the api-types package contains this, so it would make sense to have this particular exclusion inpackages/api-types/.gitignore
Line 5 in 832f76d
bundled.luau
pesde/tooling is nearly stable and complete, and I'll work towards creating releases for most common tooling, we can then migrate to dev dependencies and merge this. |
The CI install step fails because the discord-luau/packages/api-types/pesde.toml Lines 10 to 12 in 832f76d
Which references a |
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
@4x8Matrix You have missed adding the |
@CompeyDev lol I was in the api-types package when I tried to commit everything - git doesn't add things outside of the current directory - which meant only the above was commited :( fixed |
I think you're using git wrong. |
oh, thats cool |
+ updated the README for each individual package. + updated the pinned version of each package to the latest pesde release + Drafted proper README that help indicate the purpose of each package + Replace discordluau/core with discordluau/discordluau + Updated versions to be 0.0.1 instead of 0.1.0 + Updated Utilities -> Util + Improved wording on READMEs + Updated .gitignore for the bundled.luau file ! Implemented Futures over Async, we're now using Futures! I am yet to test these changes, we're still waiting on seaofvoices/darklua#144 until we can genuinely test this.
Whoops, forgot to update some calls, unticking the future impl |
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
Co-authored-by: Erica Marigold <[email protected]>
…Luau/discord-luau into feature/pesde-support-v2
This PR changes quite a bit, to go over the larger details:
script
framework, just to have a clear distinction between whats just a temporary get stuff done quickly script, vs's a genuine script, such as one used in the Cifuture
library ->async
library.Quirks, things I don't like atm: