Skip to content

Commit

Permalink
fix: ApplicationInfoData optional fields (#185)
Browse files Browse the repository at this point in the history
* fix: maje ApplicationInfoData#interactionsEndpointUrl and #roleConnectionsVerificationUrl return a Possible<Optional> to fix Discord4J/Discord4J#1243

* fix: add missing fields in ApplicationInfoData.json
  • Loading branch information
Azn9 authored Jul 19, 2024
1 parent 3f96a0e commit 8af98a3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ static ImmutableApplicationInfoData.Builder builder() {
Possible<List<String>> redirectUris();

@JsonProperty("interactions_endpoint_url")
Possible<String> interactionsEndpointUrl();
Possible<Optional<String>> interactionsEndpointUrl(); // Use of both Possible and Optional due to https://github.com/Discord4J/Discord4J/issues/1243

@JsonProperty("role_connections_verification_url")
Possible<String> roleConnectionsVerificationUrl();
Possible<Optional<String>> roleConnectionsVerificationUrl(); // Use of both Possible and Optional due to https://github.com/Discord4J/Discord4J/issues/1243

Possible<List<String>> tags();

Expand Down
2 changes: 2 additions & 0 deletions src/test/resources/rest/ApplicationInfoData.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,7 @@
],
"owner_user_id": "511972282709709995"
},
"interactions_endpoint_url": null,
"role_connections_verification_url": null,
"verify_key": "1e0a356058d627ca38a5c8c9648818061d49e49bd9da9e3ab17d98ad4d6bg2u8"
}

0 comments on commit 8af98a3

Please sign in to comment.