Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DiplomacyPanelCustom.xml #258

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

Rogue-Demon-King
Copy link
Contributor

@Rogue-Demon-King Rogue-Demon-King commented Jan 3, 2024

Removed "OverlayTextureScale" properties in line with base game files. Caused clan banners to appear stretched out and cropped.

Header Horizontal Section
Updated to Widget using Sprite with base game files as base

Diplomacy List Scrollable Panel
Rebuilt using base game files as base

Re-added Faction 2 Other Wars
It's redundant info if viewing Overview tab, but is in base game files and prefer to have it

Removed "OverlayTextureScale" properties in line with base game files. Caused clan banners to appear stretched out and cropped.

<!-- Header Horizontal Section -->
Updated to Widget using Sprite with base game files as base

<!-- Diplomacy List Scrollable Panel -->
Rebuilt using base game files as base

Re-added <!--Faction 2 Other Wars-->
It's redundant info if viewing Overview tab, but is in base game files and prefer to have it
@bennyz
Copy link
Member

bennyz commented Jan 3, 2024

thanks, can you add screenshots with the diff?

@Rogue-Demon-King
Copy link
Contributor Author

Rogue-Demon-King commented Jan 3, 2024

In game differences are very minor

Before
Diplomacy Before
After
Diplomacy After

Also fixed my original comment as I did not realise that references to xml comments were also commented in my message.

@bennyz bennyz merged commit 0988db8 into DiplomacyTeam:dev Jan 5, 2024
3 checks passed
@Rogue-Demon-King Rogue-Demon-King deleted the patch-2 branch January 5, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants