Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Color Theme and Docs/Features #38

Merged
merged 25 commits into from
Jun 16, 2024
Merged

Conversation

DogeDark
Copy link
Member

@DogeDark DogeDark commented May 8, 2024

This PR primarily revamps the use_preferred_color_scheme hook into use_system_theme.

Additionally, this PR features a few other things such as:

  • Improved docs
  • Feature name changes
  • All tests passing!
  • Fixes such as including the notification module (how did this get excluded?)
  • Clippy fixes.
  • And probably some more.

*Has breaking changes.

Closes #35

@DogeDark DogeDark added documentation Improvements or additions to documentation enhancement New feature or request labels May 8, 2024
@DogeDark DogeDark self-assigned this May 8, 2024
@marc2332 marc2332 self-requested a review May 8, 2024 06:43
sdk/src/theme/system_theme.rs Outdated Show resolved Hide resolved
@marc2332 marc2332 self-requested a review May 8, 2024 22:20
@DogeDark
Copy link
Member Author

DogeDark commented Jun 4, 2024

I have added the fix for window size. It is ready for its final review and then we can merge 🙂

@DogeDark DogeDark requested a review from marc2332 June 4, 2024 03:56
sdk/src/utils/window.rs Outdated Show resolved Hide resolved
@DogeDark DogeDark merged commit 2fbad1b into DioxusLabs:master Jun 16, 2024
4 checks passed
@DogeDark DogeDark deleted the revamp branch June 16, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop Support for use_color_scheme
2 participants