Mavenized the project #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi there |
|
Just the clone the fork that is waiting to be pulled. In this case its https://github.com/pluess/memory-measurer |
@pluess Do you guys use it in production with Java 17? |
|
Well it's a wile since I used this code. If I remember correctly, it has been working fine with JDK 1.8. Since we are no longer using it, I don't plan to put any efforts into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the memory-measurer a lot in our project. But to integrate it into our maven build we need a maven version with a valid pom.xml.
So I removed the ant based build, created an appropriate pom.xml file and reranged the file to meet the maven requirements.
As it stands know it uses Guava 18.0 which requires at least JKD 1.6.