Python Module Check #215
Open
Python Module Check #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMostDiligent
requested changes
Mar 5, 2024
There was a problem hiding this comment.
This does not work at least on Windows.
https://ci.appveyor.com/project/DiligentGraphics/diligenttools/build/job/ukjj79yvuwq4kht4
|
My bad. Forgot how to read. Should be correct now. |
MikhailGorobets
requested changes
Mar 5, 2024
TheMostDiligent
requested changes
Mar 5, 2024
|
|
||
| execute_process(COMMAND ${LIBCLANG_INSTALL_CMD} | ||
| if(NOT LIBCLANG_EXISTS EQUAL "0") |
There was a problem hiding this comment.
This condition may be too liberal as there are multiple other options for false value in CMake.
https://cmake.org/cmake/help/latest/command/if.html#constant
It should just be if(NOT LIBCLANG_EXISTS)
| RESULT_VARIABLE JINJA_EXISTS | ||
| ) | ||
|
|
||
| if(NOT JINJA_EXISTS EQUAL "0") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to see if the
libclangandjinja2modules are available to the python interpreter before attempting to install using pip. This allows a user on a system that does not manage python dependencies with pip to manually pre-install these dependencies before building.Solves #214