Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add maybeValue option on codegen options (#405) #406

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

lorenzofaresin
Copy link
Contributor

Resolve: Enhanced codegen config add maybeValue option #405

Permit to use code generation with key?: T instead key: T | null because when we define gql query without some property we expect that the undefined property doesn't exists. That's different from exists with null value

@Diizzayy Diizzayy self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #406 (3a70a7f) into main (38f922b) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   93.32%   93.34%   +0.02%     
==========================================
  Files           6        6              
  Lines         629      631       +2     
  Branches      120      120              
==========================================
+ Hits          587      589       +2     
  Misses         42       42              
Files Coverage Δ
src/generate.ts 95.00% <100.00%> (+0.06%) ⬆️
src/module.ts 89.28% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Diizzayy
Copy link
Owner

@lorenzofaresin Thanks for the PR! This looks good to me

@Diizzayy Diizzayy merged commit d77aa23 into Diizzayy:main Oct 27, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants