Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial DICOMweb assetstore support #25

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

willdunklin
Copy link
Contributor

@willdunklin willdunklin commented Oct 17, 2023

Dependant on girder/large_image#1338

Adds excludeExisiting param to DICOMweb imports, and adds dwas support for import list view

@willdunklin willdunklin force-pushed the add-dicomweb-support branch 2 times, most recently from b9adc92 to 6b52e2d Compare October 17, 2023 20:13
@willdunklin willdunklin changed the title WIP: Add DICOMweb assetstore support Add initial DICOMweb assetstore support Nov 1, 2023
@willdunklin
Copy link
Contributor Author

This PR adds basic support for DICOMweb import tracking & extends the dwas API. A follow up PR is needed to add finer-grained details such as the re-import edit button & further support for various dwas specific UI elements.

@willdunklin willdunklin requested a review from manthey November 1, 2023 15:34
@manthey
Copy link
Contributor

manthey commented Nov 2, 2023

I don't see the "View Past Imports" button next to a dicom web assetstore.

@willdunklin
Copy link
Contributor Author

Interesting, I have this button in my local dev environment
image
is this the place you're referencing on the Assetstores page?

@willdunklin
Copy link
Contributor Author

willdunklin commented Nov 3, 2023

Oh! I actually remember the source of this issue- the problem is that you have an out of date large_image. I had to make the dwas card here have an additional CSS class a while ago in order for it to be picked up by the import-tracker selectors.

@willdunklin
Copy link
Contributor Author

Addresses #23

@willdunklin willdunklin merged commit ba13e01 into main Nov 8, 2023
1 check passed
@willdunklin willdunklin deleted the add-dicomweb-support branch November 8, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants