Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/522 sort out inactive projects from search result #544

Conversation

BartvanEijkelenburg
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman or XUnit integration tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Start the dex backend project.
  2. Log in as an administrator.
  3. After you have logged in, check the two new Endpoints.
  4. Try to update the multipliers and then check if the response of the post request is adjusted as well.

Link to issue

[#522]
Closes: #522

Copy link
Contributor

@HansenSven HansenSven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely made, good commented code, good job!

API/Controllers/AlgorithmController.cs Outdated Show resolved Hide resolved
Repositories/ActivityAlgorithmRepository.cs Show resolved Hide resolved
Repositories/ActivityAlgorithmRepository.cs Show resolved Hide resolved
Repositories/ActivityAlgorithmRepository.cs Show resolved Hide resolved
Repositories/ProjectRepository.cs Show resolved Hide resolved
@NealGeilen
Copy link

Due to changes from the stakeholders. This PR will be closed.
This PR contains code that can be used in the future for a recommendations system so don't delete the branch please.

@NealGeilen NealGeilen closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to sort out inactive projects
3 participants