Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on init #96

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Run on init #96

merged 5 commits into from
Oct 31, 2024

Conversation

zoe-codez
Copy link
Member

@zoe-codez zoe-codez commented Oct 29, 2024

📬 Changes

  • Fixed tests to not load configs by default
  • altered entity references to no longer dedup based on entity_id
  • entity refs now track all active event handlers & timers
  • ref.removeAllListeners now acts a single point entity ref teardown (detach ALL handles & stop timers)
  • added removal functions for everything in hass.event
  • added removal functions for hass.socket.onConnect / onEvent
  • Added is.removeFn for creating standardized removal functions
const remove = method()
const { remove } = method()

Because I've been too inconsistent to support only one, both are being supported at the same time from the same return. Will implement this pattern throughout the project going forward

🗒️ Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed)

@zoe-codez zoe-codez marked this pull request as draft October 29, 2024 22:09
@zoe-codez zoe-codez marked this pull request as ready for review October 31, 2024 03:30
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 54.71698% with 72 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@2f92a86). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/extensions/reference.extension.ts 45.86% 71 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage        ?   72.24%           
=======================================
  Files           ?       26           
  Lines           ?     1423           
  Branches        ?      190           
=======================================
  Hits            ?     1028           
  Misses          ?      381           
  Partials        ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoe-codez zoe-codez merged commit 9b10896 into main Oct 31, 2024
5 of 6 checks passed
@zoe-codez zoe-codez deleted the runOnInit branch October 31, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant