chore: type checks as part of the build #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
yarn build
will locally always do the typechecks as part of the docker build (since you always have.env
set.)because you need to have a publicly https-exposed HA instance, which means either Nabu Casa or a ton of manual work and maintenance. If you have Nabu Casa, you can simply put the Nabu Casa entrypoint to your HA Instance as the
HASS_BASE_URL
with the appropriateHASS_TOKEN
and you're good to go; your CI will now fully check the integrity of your application in CI. When they are not set, they will simply be skipped. THIS MEANS YOUR BUILD DOESN'T HAVE TYPECHECKS IN CI, so recommend setting them.This will be documented properly.
/tools/
folder completelyChecklist
code of conduct