Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call ensure_connected on all ophyd_async devices #865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DiamondJoseph
Copy link
Contributor

Fixes #864

Instructions to reviewer on how to test:

  1. Run dodal connect i22 while on the network and able to get those PVs
  2. Ensure that devices are connected
  3. Change the PV prefixes of some devices on i22 to known invalid values
  4. Ensure that dodal connect i22 does not connect to those devices

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dodal connect on i22 is not actually connecting
1 participant