[#94]노티피케이션 커스텀 뷰 구현 #104
Open
[#94]노티피케이션 커스텀 뷰 구현 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
hyeonheebee
commented
Nov 24, 2024
| // TODO: today가 전날로 나와서 일단 하루 더함 | ||
| Date() | ||
| } | ||
| let readingScheduleCalculator = ReadingScheduleCalculator() |
There was a problem hiding this comment.
이부분 코드가 덜 지워졌네요..!
충돌수정하면서 덜 지운것 같습니다 ..!
@State private var selectedStartTime: Date = Date()
@State private var selectedReminderTime: Date = Date()
-> 삭제해도 되는 코드
let readingScheduleCalculator = ReadingScheduleCalculator()
-> 중복호출됨
| // 선택한 알람 시간 추가 | ||
| @State private var selectedStartTime: Date = Date() | ||
| @State private var selectedReminderTime: Date = Date() | ||
|
|
There was a problem hiding this comment.
여기도 마찬가지로 삭제해도 되는 코드인데 다 못지우고 푸쉬 올렸습니다..!
|
불필요한 코드 + 중복호출 부분을 다 관리하지 못하고 올렸습니다(죄송해요🥹) 해당 브랜치가 안들어가져서..일단 코멘트로 표시해놨습니다..! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
-현재 네비게이션 루트에서 emptyNotiView대신 제가 만든 노티 뷰를 받고 있어요! 그래서 알람 종을 누르면 바로 노티뷰 확인이 가능합니다
-추가로 고려해볼 사항은 노티뷰에 todo 로 적혀있고, 세니에게도 공유는 된 상태입니다 :) (책이 없을때도 노티뷰가 나옴)
-기타 추가, 수정된 코드들은 주석에 적어보았는데 혹시 이상하거나 헷갈리시면 알려주시면 감사하겠습니다!