week 3 submission #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietlq
reviewed
Oct 21, 2016
| else: | ||
| return 'False' | ||
|
|
||
| def processRequest(self, input): |
There was a problem hiding this comment.
You should split this method from the class and treat it as an independent function/method in another class. This will increase reusability of both the class & the function itself. The FinTech class should know nothing about STDIN/input. It should have only single responsibility of managing clients and talking to Client objects
vietlq
reviewed
Oct 21, 2016
| name = request[1].lower() | ||
| amount = float(request[2]) | ||
| if amount > 0: | ||
| if action == 'A': |
There was a problem hiding this comment.
Avoid magic strings. Use ACTION_ADD_CLIENT = 'A' instead
vietlq
requested changes
Oct 21, 2016
|
@vietthaotran you have 2 changes to make! 2 steps from perfection! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yay finally