Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #85

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Update deps #85

merged 9 commits into from
Dec 19, 2023

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 19, 2023

Description
Checklist
  • Formatted with nixpkgs-fmt
  • Ran tests with:
    • nix-instantiate --strict --eval --json ./default.nix -A checks.definition
    • nix-instantiate --strict --eval --json ./default.nix -A checks.helpers
    • nix-build ./default.nix -A checks.implementation
    • cargo test --manifest-path ./messenger/Cargo.toml
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)

@cole-h
Copy link
Member

cole-h commented Dec 19, 2023

Letting my approval stand, but we should validate the integration tests still pass with the nixpkgs bump.

@grahamc
Copy link
Member Author

grahamc commented Dec 19, 2023

Assigning to @cole-h to debug the test failure unless I get to it first (probably won't.)

@cole-h
Copy link
Member

cole-h commented Dec 19, 2023

Fixed up the implementation tests. All good now.

@cole-h cole-h merged commit 3cb53ec into main Dec 19, 2023
7 checks passed
@cole-h cole-h deleted the update-deps branch December 19, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants