Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to send diagnostics should not fail the install #1308

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Failing to send diagnostics should not fail the install #1308

merged 1 commit into from
Nov 21, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Nov 21, 2024

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc enabled auto-merge (squash) November 21, 2024 19:30
@grahamc grahamc merged commit 82a64a3 into main Nov 21, 2024
21 checks passed
@grahamc grahamc deleted the cole/fh-456-nix-installer-should-handle-diagnostic-reporting-failures branch November 21, 2024 19:36
@cole-h cole-h added this to the 0.30.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cole-h @grahamc