-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for building on linux #33
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanodan
commented
Apr 17, 2024
- CMake: Remove hardcoding of C & C++ compiler executables
- Rename min/max to MIN/MAX
- CMake: Use string-append rather than list-append for flags
- osiris_import.h: Don't redefine size_t
- netcon/includes/inetgetfile.h: Comment <linux/ipx.h>
- Chttpget.cpp: Fix return type
- CMake: Add -std=c++98 to C++ flags
This avoids conflicts with gcc headers. $ git grep -l -z -E '\b(min|max)\(' | xargs -0 sed -i -e 's;\bmin(;MIN(;g' -e 's;\bmax(;MAX(;g'
Otherwise it ends up being semi-colon separated, meaning command separation.
Does not seems to exists anymore
Doesn't build :-(
|
There numerous merge conflicts already. It's worth to wait #45 and try on base of main branch. |
So I've reviewed each commit in this PR and each one has already been fixed by another PR. You can safely close this PR with merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.