Add PlayerTag.view_distance tag & mech #2694
Open
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can add that as providing no input to the mechanism (although make sure that's actually the case? the JD doesn't seem to mention that at a glance). |
|
fixed |
tal5
reviewed
Jan 14, 2025
| // @group paper | ||
| // @description | ||
| // Sets this player's view distance. Input must be a number between 2 and 32. | ||
| // This will be reset when a player rejoins. Provide empty input to unset. |
There was a problem hiding this comment.
When allowing no input, it's usually no input at all (I.e. use the register method without a required param, and Provide no input in the meta).
|
should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
player.view_distance- returns player's view distanceplayer.view_distance- adjust player's view distanceRequested on discord https://discord.com/channels/315163488085475337/1320439849425305811
Note
Player#setViewDistancealso supports-1as an input (this resets player's viewdistance to match world's view distance) should I add this option as well?