Modernized WorldTag #2659
Open
Modernized WorldTag #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Need some feedback on the getGameRuleOrDefault method. Should it be static?
| @@ -344,6 +344,15 @@ public class BukkitImplDeprecations { | |||
| // Bad candidate for bumping, targets extremely commonly used naming, some of which may be hard to remove (eg stored in flag data). | |||
| public static Warning oldSpigotNames = new FutureWarning("oldSpigotNames", "Several features (particles, entities, etc.) had alternative naming added by Spigot, which are now deprecated in favor of the official Minecraft naming; see relevant feature's meta docs for more information."); | |||
|
|
|||
| // Added 2024/12/23, deprecate officially by 2028. | |||
| public static Warning timePeriod = new FutureWarning("timePeriod", "'time.period' is deprecated in favor of 'time_period'."); | |||
There was a problem hiding this comment.
just do one deprecation for all of world.time, and use pointlessSubtagPrefix
tal5
reviewed
Dec 24, 2024
Comment on lines
-1485
to
1534
| if (getGameRuleOrDefault(GameRule.DO_WEATHER_CYCLE) && world.hasStorm()) { | ||
| if (world.getGameRuleValue(GameRule.DO_WEATHER_CYCLE) == null) { | ||
| if (world.getGameRuleDefault(GameRule.DO_WEATHER_CYCLE) == null) { | ||
| throw new IllegalStateException("World " + world.getName() + " contains no GameRule " + GameRule.DO_WEATHER_CYCLE.getName()); | ||
| } | ||
| } | ||
| if (world.hasStorm()) { | ||
| NMSHandler.worldHelper.clearWeather(world); | ||
| } |
There was a problem hiding this comment.
Pretty sure this is a breaking change because the actual value of the gamerule isn't checked anymore - but is there any reason this was changed/can't just use the method anymore?
| @@ -1482,14 +1524,44 @@ public void adjust(Mechanism mechanism) { | |||
| NMSHandler.worldHelper.wakeUpAllPlayers(world); | |||
| } | |||
| // minor change: prior to 1.18, hasStorm/isRaining was not checked | |||
| if (getGameRuleOrDefault(GameRule.DO_WEATHER_CYCLE) && world.hasStorm()) { | |||
| if (world.getGameRuleValue(GameRule.DO_WEATHER_CYCLE) == null) { | |||
| if (world.getGameRuleDefault(GameRule.DO_WEATHER_CYCLE) == null) { | |||
There was a problem hiding this comment.
wait what why is this here twice
| @@ -614,8 +615,10 @@ public static void register() { | |||
| // @returns DurationTag | |||
| // @description | |||
| // Returns the relative in-game time of this world as a duration. | |||
There was a problem hiding this comment.
replace the description with a deprecation notice as well. Look at other deprecated tags for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.fullin favor oftime_fulltime.durationin favor oftime_durationtime.periodin favor oftime_period