feat(main): adaption of width to general HTML #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classix-od
force-pushed
the
html_width
branch
3 times, most recently
from
46a0f1c
to
ec1d40f
Compare
The plugin handles now rows including HTML elements and not only text. Lodash is no more needed. Fixed build errors, updated dependancies to lastest versions, generated files are all under /dist minWidth and maxWidth are now respected
classix-od
force-pushed
the
html_width
branch
from
ec1d40f
to
ee22e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old plugin measured the width of a cell assuming that cell contents consist only of text. If any cell included DOM elements such divs, styling elements, images ... etc. the plugin would compute false widths. In my update, the code computes the width of the cell contents using JQuery's width() method.
Furthermore, the update respects custom column resizing and skipped the computation of column width in the case of the user had changed the width of a column himself.
minWidth and maxWidth are now respected.
The dependency on lodash is eliminated because it's no more needed.
The dependencies were updated to the latest versions and the webpack configuration file was changed accordingly.
tsconfig.js was also minorly modified to save the output of the TypeScript compiler in a separate folder within dist.
To avoid tsc -d errors I marked all interfaces with an "export".
The build process does not show any errors now.