-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(api) added configuration.apiVersion to all secret server API calls #27
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Bill Hamilton <[email protected]>
Signed-off-by: Bill Hamilton <[email protected]>
Signed-off-by: Bill Hamilton <[email protected]>
Signed-off-by: Bill Hamilton <[email protected]>
Signed-off-by: Bill Hamilton <[email protected]>
@tylerezimmerman There seems to be an issue setting ENV var values. Would you happen to know anything about this? |
@delinea-sagar @DelineaXPM/ss-write can someone take a look at environmental variables failure for @pacificcode since they were changed last month I see he's getting failures on these. |
I checked and didn't see Also note this test seems to have failed in earlier PRs as well, see this check from prior pr |
Added configuration.apiVersion to all secret server API calls.
Fixed code so all linters run successfully
Fixed unit tests to work with newest versions of SS api calls and to run successfully.
Pull request checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Currently all API calls to secret server are using api/v1 ... some of these API's have been updated to api/v2.
What is the new behavior?
Does this introduce a breaking change?
If yes, please describe...
Other relevant information