Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(api) added configuration.apiVersion to all secret server API calls #27

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pacificcode
Copy link
Contributor

@pacificcode pacificcode commented May 9, 2024

Added configuration.apiVersion to all secret server API calls.
Fixed code so all linters run successfully
Fixed unit tests to work with newest versions of SS api calls and to run successfully.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • You have read the contributing guide
  • Tests for the changes have been added
  • The documentation has been reviewed and updated as needed

What is the current behavior?

Currently all API calls to secret server are using api/v1 ... some of these API's have been updated to api/v2.

What is the new behavior?

  • All calls to functions accessResource() & searchResources() now include a new parameter to determine the version of the requested API to call.

Does this introduce a breaking change?

  • Yes
  • No

If yes, please describe...

Other relevant information

@pacificcode
Copy link
Contributor Author

@tylerezimmerman There seems to be an issue setting ENV var values. Would you happen to know anything about this?

@sheldonhull sheldonhull requested a review from delinea-sagar May 10, 2024 18:12
@sheldonhull
Copy link

sheldonhull commented May 10, 2024

@delinea-sagar @DelineaXPM/ss-write can someone take a look at environmental variables failure for @pacificcode since they were changed last month I see he's getting failures on these.

@delinea-sagar
Copy link
Member

delinea-sagar commented May 11, 2024

With the inclusion of platform login support, it's necessary to configure environment variables for platform details in order to execute tests. Use same secret server which is configured with platform. This ensures consistency in details such as secret ID and folder ID for running test cases directly on the secret server instance as well as via the platform.
image

@sheldonhull
Copy link

sheldonhull commented May 23, 2024

instance

I checked and didn't see TSS_SERVER_URL set in the actions secrets. Mind double checking and let @pacificcode know more specifically what he might be missing if it's something else?

Also note this test seems to have failed in earlier PRs as well, see this check from prior pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants