Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend improvements 5 #158

Merged
merged 6 commits into from
Jun 16, 2024
Merged

Frontend improvements 5 #158

merged 6 commits into from
Jun 16, 2024

Conversation

Delemangi
Copy link
Owner

@Delemangi Delemangi commented Jun 16, 2024 •
edited
Loading

  • When clicking download on an encrypted file, scroll to password box at the top of the page
  • Also scroll for sharing box
  • Set all text inputs required, as well as placeholders
  • Improve file upload box
  • Use Anchor components instead of a elements wherever possible
  • Set opacity to 1 of overlays, because of leaking information from behind
  • Set minimum password length for file encryption to 5
  • Disallow sharing files with self
  • Improve file sharing box
  • Fix overflowing in webhooks table

@Delemangi
Refactor
089750e 
Signed-off-by: Delemangi <[email protected]>
@Delemangi Delemangi self-assigned this Jun 16, 2024
Delemangi added 4 commits June 16, 2024 13:52
@Delemangi
Optimize imports
8bf2b50 
Signed-off-by: Delemangi <[email protected]>
@Delemangi
Improve file sharing box
9c425d0 
Signed-off-by: Delemangi <[email protected]>
@Delemangi
Truncate text
2021858 
Signed-off-by: Delemangi <[email protected]>
@Delemangi
Add padding
8a1c14e 
Signed-off-by: Delemangi <[email protected]>
@Delemangi Delemangi marked this pull request as ready for review June 16, 2024 12:15
@Delemangi
Scroll to top
a45462a 
Signed-off-by: Delemangi <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Delemangi Delemangi merged commit a3d5404 into main Jun 16, 2024
16 checks passed
@Delemangi Delemangi deleted the frontend-improvements-5 branch June 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani2221 dani2221 Awaiting requested review from dani2221

@amatanasovska amatanasovska Awaiting requested review from amatanasovska

@alekjarmov alekjarmov Awaiting requested review from alekjarmov

Assignees

@Delemangi Delemangi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Delemangi