Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sdk issues #76

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fix/sdk issues #76

merged 2 commits into from
Aug 1, 2024

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Aug 1, 2024

Summary by CodeRabbit

  • New Features

    • Transitioned wallet application to mainnet with updated API endpoints for live deployment.
    • Introduced new notification methods in RPCManager for login state changes and iframe readiness.
    • Added a new LoginChangedRequest type for better login state management.
  • Bug Fixes

    • Improved responsiveness of wallet to user authentication states.
  • Documentation

    • Updated environment variables for development and testing configurations.
  • Refactor

    • Simplified authentication handling by removing unused parameters and types.
  • Chores

    • Enhanced development setup with SSL support in Vite configuration.

Copy link

coderabbitai bot commented Aug 1, 2024

Walkthrough

The recent changes transition the wallet application and its SDK from a test environment to a production environment, enhancing connectivity to live services. Key updates include modifications to environment variables, the integration of an RPC Manager for better session handling, and refinements in type definitions and URL generation. These enhancements aim to improve user authentication management and streamline code structure, ultimately supporting a more robust and responsive application.

Changes

File(s) Change Summary
apps/wallet/.env Updated environment variables for transitioning from TestNet to Mainnet, including new API endpoints.
apps/wallet/src/App.tsx Enhanced integration with rpcManager for improved user login state management.
apps/wallet/src/main.tsx Removed imports and conditional logic related to the runtime environment, simplifying execution flow.
apps/wallet/src/pages/password/create.tsx Removed unused import from crypto-js, streamlining the code.
apps/wallet/src/stores/rpc.ts Added new methods notifyReady and notifyLoginChanged for better RPC connection management and session handling.
packages/sdk/.env Updated production and testing URLs, directing to live endpoints.
packages/sdk/src/lib/dom/index.ts Removed auth parameter from HibitIdIframe constructor, simplifying the authentication process.
packages/sdk/src/lib/enums.ts Added IFRAME_READY and LOGIN_CHANGED to ClientExposeRPCMethod enum for new notifications.
packages/sdk/src/lib/index.ts Removed UserAuthInfo type; added LoginChangedRequest type to manage login state changes.
packages/sdk/src/lib/types.ts Removed UserAuthInfo interface and added LoginChangedRequest interface to redefine authentication handling.
packages/sdk/src/lib/utils.ts Simplified getHibitIdUrl function by removing the auth parameter, altering URL generation logic.
packages/sdk/src/lib/wallet.tsx Enhanced HibitIdWallet class for session management; refined iframe handling and introduced new methods for login state changes.
packages/sdk/vite.config.ts Added basicSsl plugin for SSL support in development, improving local security.
scripts/build_testnet.sh Included additional exports for configuring test network environment variables.
turbo.json Modified tasks for @deland-labs/hibit-id-sdk and @deland-labs/hibit-id-wallet to utilize environment variables for improved configurability.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Wallet
    participant RPCManager
    participant API

    User->>Wallet: Login Request
    Wallet->>RPCManager: Init login process
    RPCManager->>API: Notify login state
    API-->>RPCManager: Login successful
    RPCManager-->>Wallet: Notify login changed
    Wallet-->>User: Login successful response
Loading

🐇 In a world so bright and grand,
A wallet hops with a joyful band.
With APIs now shining clear,
Our code dances, full of cheer!
From test to main, we take a leap,
For secure connections, our hearts do leap! 🌟


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Aug 1, 2024

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-n9fffrvam-delandlabs-projects.vercel.app

Built with commit a415b86.
This pull request is being automatically deployed with vercel-action

@rustin01 rustin01 merged commit c2216c4 into main Aug 1, 2024
2 checks passed
@rustin01 rustin01 deleted the fix/sdk-issues branch August 1, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant