Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/networth usdt #189

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fix/networth usdt #189

merged 2 commits into from
Oct 30, 2024

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Oct 30, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new query for calculating the net worth of tokens in a specified chain.
    • Enhanced the TokenDetailPage and WalletMainPage to display dynamic net worth information.
  • Improvements

    • Updated token-related queries for better handling of balance and fiat value calculations.
    • Improved URL encoding for token icons to ensure proper display.
  • Bug Fixes

    • Adjusted the logic in the TokenListItem and TokenDetailPage components to ensure accurate retrieval of token values.

Copy link

coderabbitai bot commented Oct 30, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple files in the wallet application. A new entry, GET_CHAIN_NET_WORTH, has been added to the QueryCacheKey enum. The useChainTokenNetWorthQuery function has been created to calculate the net worth of tokens in a specified chain. Additionally, the useTokenFiatValueQuery function has been modified to remove the balance parameter, and related components have been updated to reflect this change. The TokenIcon component now properly encodes asset symbols for URL construction.

Changes

File Change Summary
apps/wallet/src/apis/react-query/query-keys.ts Added enum entry: GET_CHAIN_NET_WORTH = 'getChainNetWorth' in QueryCacheKey.
apps/wallet/src/apis/react-query/token.ts - Added method: useChainTokenNetWorthQuery(chain: ChainInfo).
- Updated useTokenFiatValueQuery to remove balance parameter.
apps/wallet/src/components/TokenIcon.tsx Modified TokenIcon to use URL-encoded token.assetSymbol for constructing srcUrl.
apps/wallet/src/components/TokenList.tsx Updated TokenListItem to call useTokenFiatValueQuery with only token as an argument.
apps/wallet/src/pages/main/index.tsx Added netWorthQuery utilizing useChainTokenNetWorthQuery to display user's net worth.
apps/wallet/src/pages/token-detail/index.tsx Updated TokenDetailPage to call useTokenFiatValueQuery with only tokenQuery.data.

Possibly related PRs

  • feat: sign test and chainassetType update #176: The changes in apps/wallet/src/apis/react-query/token.ts regarding the useAllAssetListQuery function may relate to the new GET_CHAIN_NET_WORTH entry in the main PR, as both involve handling asset types and queries within the same module.

🐰 In the world of tokens, we hop and play,
New worth to measure, come what may!
With queries so bright, and symbols so clear,
Our wallet's now smarter, let's give a cheer!
From balance to value, we dance with delight,
In the garden of code, everything feels right! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustin01 rustin01 merged commit 39cf5f8 into main Oct 30, 2024
1 check passed
@rustin01 rustin01 deleted the fix/networth-usdt branch October 30, 2024 08:24
Copy link

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-gj1z8829h-delandlabs-projects.vercel.app

Built with commit 1c82eb0.
This pull request is being automatically deployed with vercel-action

rustin01 added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant