Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve send token #175

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Feat/improve send token #175

merged 2 commits into from
Oct 20, 2024

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Oct 20, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new fee query mechanism for better fee estimation in the token sending process.
    • Enhanced loading state management for displaying token balances and fees.
  • Bug Fixes

    • Updated loading conditions to improve the accuracy of loading indicators across various components.
  • Improvements

    • Streamlined code for fee calculations and balance checks, enhancing overall performance and clarity.

Copy link

coderabbitai bot commented Oct 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve updates across several components in the wallet application. Key modifications include the introduction of a new useFeeQuery function for streamlined fee calculations, adjustments to loading state management for better clarity, and enhancements to the DfinityChainWallet class to implement a caching mechanism for estimated fees. The updates aim to improve the efficiency and responsiveness of the user interface while maintaining existing functionalities.

Changes

File Path Change Summary
apps/wallet/src/components/TokenList.tsx Updated conditional rendering from balanceQuery.isFetching to balanceQuery.isLoading for loading state display.
apps/wallet/src/pages/send-token/confirm-page.tsx Replaced inline fee query logic with useFeeQuery, adjusted minNativeBalance calculation based on chainInfo.feeTokenType, and updated loading state checks.
apps/wallet/src/pages/send-token/index.tsx Enhanced useForm with watch, integrated useFeeQuery, modified handleSend, and updated loading state management for maximum amount button.
apps/wallet/src/pages/send-token/store.ts Introduced useFeeQuery function to fetch estimated fees based on input parameters, with updated import statements.
apps/wallet/src/pages/token-detail/index.tsx Updated conditional rendering from balanceQuery.isFetching to balanceQuery.isLoading for loading state display.
apps/wallet/src/utils/chain/chain-wallets/dfinity/index.ts Added feeCache property for caching fees, updated getEstimatedFee method to utilize this cache for efficiency.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SendTokenPage
    participant FeeQuery
    participant ConfirmPage

    User->>SendTokenPage: Inputs amount, token, address
    SendTokenPage->>FeeQuery: Calls useFeeQuery
    FeeQuery-->>SendTokenPage: Returns estimated fee
    SendTokenPage->>ConfirmPage: Navigates with fee data
Loading

🐰 "In the wallet where tokens flow,
A fee query now helps us know.
With loading states clear as day,
We hop along our merry way!
Caching fees, oh what a treat,
Making transactions quick and neat!" 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustin01 rustin01 merged commit e0beb04 into main Oct 20, 2024
2 checks passed
@rustin01 rustin01 deleted the feat/improve-send-token branch October 20, 2024 04:25
Copy link

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-6ycgvprcu-delandlabs-projects.vercel.app

Built with commit bec961d.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant