Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more compact led representations #66

Merged
merged 6 commits into from
Feb 8, 2024
Merged

more compact led representations #66

merged 6 commits into from
Feb 8, 2024

Conversation

DavJCosby
Copy link
Owner

See #65

Analyzing the performance tradeoffs of this design decision

note: benchmark code got some changes that improved performance as angle representations changed
@DavJCosby DavJCosby linked an issue Feb 7, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 7, 2024

Benchmark for bc111e2

Click to view benchmark
Test Base PR %
quirky_trail 78.8±1.05ms 127.1±1.30ms +61.29%
ripples 48.4±11.12ms 44.7±13.56ms -7.64%

Copy link

github-actions bot commented Feb 7, 2024

Benchmark for 3c71ce6

Click to view benchmark
Test Base PR %
quirky_trail 75.7±0.22ms 127.4±0.95ms +68.30%
ripples 47.6±11.35ms 40.6±14.26ms -14.71%

Copy link

github-actions bot commented Feb 7, 2024

Benchmark for 235fa5a

Click to view benchmark
Test Base PR %
quirky_trail 75.9±0.99ms 126.5±0.99ms +66.67%
ripples 45.5±12.43ms 45.6±9.16ms +0.22%

Copy link

github-actions bot commented Feb 8, 2024

Benchmark for 309c7ca

Click to view benchmark
Test Base PR %
quirky_trail 77.0±0.27ms 126.2±0.91ms +63.90%
ripples 50.6±6.04ms 45.4±11.65ms -10.28%

Copy link

github-actions bot commented Feb 8, 2024

Benchmark for 67a8d7a

Click to view benchmark
Test Base PR %
quirky_trail 75.6±0.21ms 77.5±0.58ms +2.51%
ripples 44.3±11.89ms 51.5±8.25ms +16.25%

Copy link

github-actions bot commented Feb 8, 2024

Benchmark for 0c76624

Click to view benchmark
Test Base PR %
quirky_trail 75.8±0.71ms 78.6±0.78ms +3.69%
ripples 43.4±13.14ms 42.6±12.90ms -1.84%

@DavJCosby DavJCosby merged commit 2fed25a into master Feb 8, 2024
2 checks passed
@DavJCosby DavJCosby deleted the smaller-leds branch February 8, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debulk LED structs
1 participant