-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distance-based mutator adjustments, extended api #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavJCosby
added
e/api
Improving a method in the API, or adding a new one
e/performance
Changes intended to improve performance
labels
Dec 12, 2023
Benchmark for c34aa22Click to view benchmark
|
Catch new-api up to master
Benchmark for 851b759Click to view benchmark
|
Benchmark for 4963962Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
e/api
Improving a method in the API, or adding a new one
e/performance
Changes intended to improve performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements:
set_at_dir_from()
,set_at_angle_from()
get_closest()
,get_closest_mut()
,set_closest()
get_closest_to()
,get_closest_to_mut()
,set_closest_to()
forVec<&Led>
andVec<&mut Led>
Improves most get/set at/within implementations. Those that are relative to the center point make use of each led's distance property to skip some of the more complicated steps the other methods have to take.