Fix extensions loading and parsing #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use NULL as array terminator and don't store the count of extensions anymore
Dav1dde
reviewed
Dec 26, 2023
Check if functions are usable and fallback on old method if they are not.
|
I fixed the test failure (superfluous comma) and all tests now build fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #446 by being more flexible when parsing extensions.
If the array version is available, it is used, else, it falls back on space separated string.
In addition, if the implementation doesn't have any extension, parsing doesn't fail anymore and if malloc fails, extensions parsing fails.