Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add telemetry event for breaking change analysis #588

Merged

Conversation

popcornylu
Copy link
Contributor

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Chore

What this PR does / why we need it:
Add telemetry events. We would like to track the usage for the breaking change analysis feature. The question to ask

  • How many active users enable this feature
  • How many(percentage) users create run when breaking change analysis is enabled
  • How many(percentage) users create check when breaking change analysis is enabled

FrontEnd
Event type: [Experiment] breaking_change_analysis

{
   'enabled': true
}

Backend
Event type: api_event (existing)

{
  'action': 'create_run',
  'track_props': {
     'breaking_change_analysis': true
  }
}
{
  'action': 'create_check',
  'track_props': {
     'breaking_change_analysis': true
  }
}

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
recce/apis/check_api.py 49.57% <100.00%> (+0.43%) ⬆️
recce/apis/run_api.py 45.00% <100.00%> (+0.69%) ⬆️

... and 6 files with indirect coverage changes

Signed-off-by: popcorny <[email protected]>
@kentwelcome kentwelcome self-requested a review January 22, 2025 03:23
Copy link
Member

@kentwelcome kentwelcome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popcornylu popcornylu marked this pull request as ready for review January 22, 2025 03:29
@popcornylu popcornylu merged commit 24ab155 into main Jan 22, 2025
11 checks passed
@popcornylu popcornylu deleted the feature/drc-1037-add-telemetry-for-breaking-change-analysis branch January 22, 2025 03:30
@popcornylu popcornylu changed the title Add telemetry event for breaking change analysis [Chore] Add telemetry event for breaking change analysis Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants