Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Improvement for checklist #585

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

even-wei
Copy link
Contributor

PR checklist

  • Ensure you have added or run the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Chore

What this PR does / why we need it:

  1. Remove "Checklist > " from title
  2. Move the "Preset" label to the end of the title
  3. Add a guiding message for preset check with no result
  4. Disable the approval button when no result
  5. Move the "Rerun" icon to the run result.

Which issue(s) this PR fixes:
DRC-1023

Special notes for your reviewer:
Regarding point 3, should we have the same behavior of approving from the checkbox in the list?

Does this PR introduce a user-facing change?:

@even-wei even-wei requested a review from popcornylu January 17, 2025 10:02
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@even-wei even-wei merged commit 7f69ce4 into main Jan 20, 2025
8 checks passed
@even-wei even-wei deleted the feature/drc-1023-improvement-for-checklist branch January 20, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants