-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]support breaking change analysis #574
Merged
popcornylu
merged 15 commits into
main
from
feature/drc-1019-support-to-detect-a-model-as-non-breaking-non-ui
Jan 20, 2025
Merged
[Feature]support breaking change analysis #574
popcornylu
merged 15 commits into
main
from
feature/drc-1019-support-to-detect-a-model-as-non-breaking-non-ui
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
popcornylu
force-pushed
the
feature/drc-1019-support-to-detect-a-model-as-non-breaking-non-ui
branch
2 times, most recently
from
January 16, 2025 09:57
db5f74a
to
25f5655
Compare
Signed-off-by: popcorny <[email protected]>
popcornylu
force-pushed
the
feature/drc-1019-support-to-detect-a-model-as-non-breaking-non-ui
branch
from
January 16, 2025 10:20
25f5655
to
9226149
Compare
Signed-off-by: popcorny <[email protected]>
popcornylu
force-pushed
the
feature/drc-1019-support-to-detect-a-model-as-non-breaking-non-ui
branch
from
January 17, 2025 02:20
b036a96
to
37978c7
Compare
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Signed-off-by: popcorny <[email protected]>
Codecov ReportAttention: Patch coverage is
|
popcornylu
changed the title
[Feature]support to detect a model as non-breaking change
[Feature]support breaking change analysis
Jan 17, 2025
kentwelcome
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: popcorny <[email protected]>
popcornylu
force-pushed
the
feature/drc-1019-support-to-detect-a-model-as-non-breaking-non-ui
branch
from
January 20, 2025 08:57
39c124e
to
7f61d05
Compare
popcornylu
deleted the
feature/drc-1019-support-to-detect-a-model-as-non-breaking-non-ui
branch
January 20, 2025 09:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR support he breaking change analysis.
For modified nodes, it will use raw(templated) sql code. A node would mark as non-breaking change if
Otherwise, it would mark as breaking change.
For non-breaking change, it will not mark the downstream as impacted. See the screenshot
PR checklist
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: