Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support changed only toggling on run toolbar #310

Conversation

wcchang1115
Copy link
Collaborator

@wcchang1115 wcchang1115 commented May 8, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • If there is no change, it shows no change and cannot toggle back when toggle the "Changed only" checkbox

Which issue(s) this PR fixes:
DRC-401

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

linear bot commented May 8, 2024

Signed-off-by: Wei-Chun, Chang <[email protected]>
@wcchang1115 wcchang1115 force-pushed the bug/drc-401-bug-when-click-the-changed-only-the-toolbar-would-disappear branch from ab99b9e to 39795c4 Compare May 8, 2024 08:42
@wcchang1115 wcchang1115 changed the title [Bug] Add result view panel [Feature] Support changed only toggling on run toolbar May 8, 2024
@wcchang1115 wcchang1115 marked this pull request as ready for review May 8, 2024 10:29
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are warnings, should always show the warnings in the toolbar.

@wcchang1115 wcchang1115 merged commit 56d3b15 into main May 9, 2024
4 checks passed
@wcchang1115 wcchang1115 deleted the bug/drc-401-bug-when-click-the-changed-only-the-toolbar-would-disappear branch May 9, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants