Skip to content

Commit

Permalink
Merge pull request #525 from DataRecce/fix/drc-935-fix-recce-run-erro…
Browse files Browse the repository at this point in the history
…r-when-model-is-added-or-removed

[Fix] DRC-935 Handle the edge case when add/remove models
  • Loading branch information
popcornylu authored Dec 6, 2024
2 parents 5450c11 + a414ef8 commit 4fa2b40
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions recce/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ def schema_diff_should_be_approved(check_params: dict) -> bool:
view_mode=check_params.get('view_mode'),
)
nodes = [node for node in nodes if not node.startswith('test.')]
base = None
curr = None
for node in nodes:
base = context.get_model(node, base=True)
curr = context.get_model(node, base=False)
Expand Down

0 comments on commit 4fa2b40

Please sign in to comment.