Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-133: Code clean-up for Release Prep #142

Merged
merged 22 commits into from
Sep 24, 2024
Merged

Feature-133: Code clean-up for Release Prep #142

merged 22 commits into from
Sep 24, 2024

Conversation

doulikecookiedough
Copy link
Contributor

@doulikecookiedough doulikecookiedough commented Sep 24, 2024 •
edited
Loading

Summary of Changes:

  • Reviewed and cleaned up docstrings + pytests and reorganized code, and fixed minor bugs
  • Used poetry bump to update versioning, and bumped version number to 1.1.0
    • Added missing version info to __init__.py in src/hashstore
  • Added type hints to all method signatures

@doulikecookiedough
Update version number and authors in 'pyproject.toml'
65f4eeb
@doulikecookiedough
Review and clean up 'filehashstore_interface' test module for 'store_…
a08a6b1 
…object' & 'tag_object' pytests and resolve todo items for missing 'tag_object' pytests
@doulikecookiedough
Re-organize 'delete_if_invalid_object' in 'filehashstore' module to m…
2e67b39 
…atch java library interface order
@doulikecookiedough
Re-organize and clean up 'delete_if_invalid_object' method pytests in…
7ff4722 
… 'filehashstore' interface test module
@doulikecookiedough
Review and clean-up 'store_metadata' pytests
73226da
@doulikecookiedough
Review and clean-up 'retrieve_object' pytests
742eb88
@doulikecookiedough
Review and clean-up 'retrieve_metadata' pytests
6a1b072
@doulikecookiedough
Review and clean-up 'delete_object' pytests
1d5b215
@doulikecookiedough
Review and clean-up 'delete_metadata' pytests
cf1f11c
@doulikecookiedough
Review and clean-up 'get_hex_digest' pytests
56a4315
@doulikecookiedough
Fix bug in 'find_object' where sysmeta path was not returned due to i…
9ea9572 
…ncorrect method call (isdir vs. exists), and clean-up & review find_object pytests
@doulikecookiedough
Re-organize 'find_object' pytests and filehashstore code placement
2b0346a
@doulikecookiedough
Cleanup 'filehashstore' pytests module part 1 via reorganization and …
cdf377b 
…deleting redundant comments and code
@doulikecookiedough
Cleanup remaining 'filehashstore' pytests module for core methods
b9d216c
@doulikecookiedough
Cleanuo 'filehashstore' utility and supporting methods pytests part 1…
1582505 
… and add new pytest for '_is_string_in_refs_file'
@doulikecookiedough
Revise exception messaging in '_verify_object_information', review py…
d58d5e8 
…tests and add new pytest
@doulikecookiedough
Refactor private '_delete' method and clean-up remaining pytests
d49cdfa
@doulikecookiedough
Revert 'pyproject.toml' version and add version to 'hashstore/__init_…
3ab2309 
…_.py' to prepare use of poetry bump version
@doulikecookiedough
Add poetry bump version code to 'pyproject.toml'
22624db
@doulikecookiedough
Update version to '1.1.0' via 'poetry version minor'
50b8f8d
@doulikecookiedough
Update 'README.md'
e780711
@doulikecookiedough
Add type hints to all method signatures, fix minor issues related to …
44b1f79 
…typing inconsistencies and revise affected pytests
@doulikecookiedough doulikecookiedough merged commit b4b6e82 into develop Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doulikecookiedough