Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data_source_datadog_service_account] acc test: reproduce service account datasource bug on exact match filter #2574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pablito-perez
Copy link
Contributor

@pablito-perez pablito-perez commented Sep 11, 2024

Reproduces the behaviour described in #2571

TL;DR exact_match filter on service_account might be incorrect when the API returns multiple items

Copy link
Contributor Author

pablito-perez commented Sep 11, 2024

@pablito-perez pablito-perez marked this pull request as ready for review September 11, 2024 08:42
@pablito-perez pablito-perez requested review from a team as code owners September 11, 2024 08:42
@pablito-perez pablito-perez changed the title reproduce service account datasource bug on exact match filter acc test: reproduce service account datasource bug on exact match filter Sep 11, 2024
{
Config: testAccDatasourceServiceAccountConfigMatchExact(email, name),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttrPair("data.datadog_service_account.test", "id", "datadog_service_account.foo", "id"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this condition will fail with the current codebase

@pablito-perez pablito-perez changed the title acc test: reproduce service account datasource bug on exact match filter [data_source_datadog_service_account] acc test: reproduce service account datasource bug on exact match filter Sep 11, 2024
@pablito-perez pablito-perez force-pushed the pablo.perez/data-service-account-exact-match-test branch 2 times, most recently from 27395b7 to ccda8e7 Compare September 11, 2024 09:20
@pablito-perez pablito-perez force-pushed the pablo.perez/data-service-account-exact-match-test branch from ccda8e7 to 15271e3 Compare September 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant