Robertomonteromiguel/telemetry py poc #3293
Draft
+90
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.stdout(f"[tag:{weblog_docker_tag}] Building weblog app on base image [{self.ssi_all_docker_tag}].") | ||
| logger.stdout( | ||
| f"0000[tag:{weblog_docker_tag}] Building weblog app on base image [{self.ssi_all_docker_tag}]." | ||
| ) |
There was a problem hiding this comment.
forget this
| sudo curl https://pyenv.run | bash | ||
| export PATH="$PYENV_ROOT/bin:$PATH" | ||
| eval "$(pyenv init -)" | ||
| export PATH="~/.pyenv/bin:$PATH" && eval "$(pyenv init -)" && pyenv install "$PY_VERSION" && pyenv global "$PY_VERSION" |
There was a problem hiding this comment.
ok, I achieve to install a version of python, but I have some problems with the path.
It's imcomplete we should recibe the python version parameter 'PYTHON_VERSION=$1'
| @@ -0,0 +1,10 @@ | |||
| ARG BASE_IMAGE | |||
|
|
|||
| FROM ${BASE_IMAGE} | |||
There was a problem hiding this comment.
Dynamic From
| UBUNTU22_PY_APP = WeblogDescriptor( | ||
| "py-app", | ||
| "python", | ||
| [SupportedImages().UBUNTU_22_ARM64.add_allowed_runtime_version(PythonRuntimeInstallableVersions.PY39)], |
There was a problem hiding this comment.
Here all supported versions for python and ubuntu 22. Take a look to Java app
| @@ -116,6 +145,11 @@ def get_version_id(version): | |||
| JAVA7_APP = WeblogDescriptor("java7-app", "java", [SupportedImages().UBUNTU_22_ARM64]) | |||
| WEBSPHERE_APP = WeblogDescriptor("websphere-app", "java", [SupportedImages().WEBSPHERE_AMD64]) | |||
| JBOSS_APP = WeblogDescriptor("jboss-app", "java", [SupportedImages().JBOSS_AMD64]) | |||
| UBUNTU22_PY_APP = WeblogDescriptor( | |||
There was a problem hiding this comment.
Better to change the name from "UBUNTU22_PY_APP" to "PY_APP"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present