-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robertomonteromiguel/telemetry py poc #3293
base: main
Are you sure you want to change the base?
Conversation
logger.stdout(f"[tag:{weblog_docker_tag}] Building weblog app on base image [{self.ssi_all_docker_tag}].") | ||
logger.stdout( | ||
f"0000[tag:{weblog_docker_tag}] Building weblog app on base image [{self.ssi_all_docker_tag}]." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forget this
sudo curl https://pyenv.run | bash | ||
export PATH="$PYENV_ROOT/bin:$PATH" | ||
eval "$(pyenv init -)" | ||
export PATH="~/.pyenv/bin:$PATH" && eval "$(pyenv init -)" && pyenv install "$PY_VERSION" && pyenv global "$PY_VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I achieve to install a version of python, but I have some problems with the path.
It's imcomplete we should recibe the python version parameter 'PYTHON_VERSION=$1'
@@ -0,0 +1,10 @@ | |||
ARG BASE_IMAGE | |||
|
|||
FROM ${BASE_IMAGE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dynamic From
UBUNTU22_PY_APP = WeblogDescriptor( | ||
"py-app", | ||
"python", | ||
[SupportedImages().UBUNTU_22_ARM64.add_allowed_runtime_version(PythonRuntimeInstallableVersions.PY39)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here all supported versions for python and ubuntu 22. Take a look to Java app
@@ -116,6 +145,11 @@ def get_version_id(version): | |||
JAVA7_APP = WeblogDescriptor("java7-app", "java", [SupportedImages().UBUNTU_22_ARM64]) | |||
WEBSPHERE_APP = WeblogDescriptor("websphere-app", "java", [SupportedImages().WEBSPHERE_AMD64]) | |||
JBOSS_APP = WeblogDescriptor("jboss-app", "java", [SupportedImages().JBOSS_AMD64]) | |||
UBUNTU22_PY_APP = WeblogDescriptor( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to change the name from "UBUNTU22_PY_APP" to "PY_APP"
Motivation
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present