Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to enable telemetry tests for python [INPLAT-36] #3284

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

emmettbutler
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@emmettbutler emmettbutler requested a review from a team as a code owner October 22, 2024 14:19
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to define python weblogs in utils/docker_ssi/docker_ssi_definitions.py

cc @robertomonteromiguel

@robertomonteromiguel
Copy link
Collaborator

Yes, I think we can set this PR as draft, because we need to add the python scripts, docker files....
@iamluc is looking that too

@robertomonteromiguel robertomonteromiguel marked this pull request as draft October 22, 2024 16:25
@emmettbutler
Copy link
Contributor Author

@robertomonteromiguel let me know if this looks right to you. I believe I've got it all working with the exception of the tests actually passing, since there's a known issue with Python wherein it doesn't send SSI telemetry (iirc).

@emmettbutler emmettbutler changed the title attempt to enable telemetry tests for python attempt to enable telemetry tests for python [INPLAT-36] Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants