[PLINT-542] Add machines metrics #19285
Open
+281
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-witt
changed the base branch from
master
to
sarah/add-octopus-integration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| ] | ||
| machine_tags += roles | ||
| self.gauge("machine.count", 1, tags=self._base_tags + machine_tags) | ||
| self.gauge("machine.is_healthy", is_healthy, tags=self._base_tags + machine_tags) |
There was a problem hiding this comment.
What is the purpose of also reporting it as a metric if we already report it as a tag?
There was a problem hiding this comment.
It's easier to monitor on, and the tag gives more specific/detailed information
| roles = machine.get("Roles", []) | ||
| health_status = machine.get("HealthStatus", None) | ||
| is_healthy = health_status.startswith("Healthy") | ||
| machine_tags = [ |
There was a problem hiding this comment.
What do you think about adding OperatingSystem as a machine_os tag?
| "Uri": "hostname-test:10933/", | ||
| "IsDisabled": false, | ||
| "MachinePolicyId": "MachinePolicies-1", | ||
| "HealthStatus": "Healthy", |
There was a problem hiding this comment.
We're only testing HealthStatus with Healthy value
steveny91
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for collecting metrics about machines and deployment targets
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged