Sy/dns change #19276
Open
Sy/dns change #19276
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadhemiDD
approved these changes
Dec 24, 2024
Kyle-Neale
reviewed
Dec 24, 2024
| resolver.query(self.hostname) | ||
| except dns.resolver.NXDOMAIN: | ||
| pass | ||
| response_time = get_precise_time() - t0 |
There was a problem hiding this comment.
Why do we still want to get the response time from a record we fail to query? Maybe I'm missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We time response time by setting a timestamp then running some code and then calculate the time it took to ran that code. Setting the timestamp closer to the actual line of code that needs to be timed can help get a more accurate reading on the response time.