[mongo] use queryPlanner verbosity when explaining long running queries #19232
+141
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenadnoveljic
previously approved these changes
Dec 10, 2024
| @@ -229,6 +229,9 @@ def is_collection_sharded(self, db_name, coll_name): | |||
| self._log.warning("Could not determine if collection %s.%s is sharded: %s", db_name, coll_name, e) | |||
| return False | |||
|
|
|||
| def explain_command(self, db_name, command, verbosity="executionStats", session=None): | |||
There was a problem hiding this comment.
Shall we add typing to the function's arguments and return value?
There was a problem hiding this comment.
i will do it in a separate pr because the entire api.py does not have type hint
nenadnoveljic
approved these changes
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
mongointegration to use the queryPlanner verbosity mode when collecting explain plans for queries with a duration longer than the configured timeout (default: 30s). This change avoids re-executing long-running queries on the monitored database, improving performance and reducing resource contention.Motivation
https://datadoghq.atlassian.net/browse/DBMON-4823
Currently, the MongoDB integration collects explain plans using the executionStats verbosity mode, which executes the winning plan to completion for detailed execution statistics. This approach introduces two significant issues for long-running queries:
Switching to the queryPlanner mode resolves these issues by running the MongoDB query optimizer to determine the winning plan without executing the query to completion. This change reduces overhead and improves stability for monitoring.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged