-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gitlab's multi-project pipelines to trigger agent build #19130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise:
Truly lovely to see all those polling scripts removed !
LGTM on GitLab pipeline definition 💯
Small question on the manually triggered pipeline in case you want to always have it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
What does this PR do?
Before
We curled gitlab API in 2 jobs. The token for those expired, so they broke.
After
We use gitlab's built-in multi-project pipelines.
We can see the status of the agent build in the
dd-gitlab/default-pipeline
"action". See screenshot below:Motivation
No need for a separate token, better retries. Clearer Pipeline UI.
Thanks to @BaptisteLalanne for all the support!
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged