Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gitlab's multi-project pipelines to trigger agent build #19130

Merged
merged 17 commits into from
Jan 11, 2025

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Nov 25, 2024

What does this PR do?

Before

We curled gitlab API in 2 jobs. The token for those expired, so they broke.

After

We use gitlab's built-in multi-project pipelines.
We can see the status of the agent build in the dd-gitlab/default-pipeline "action". See screenshot below:
image

Motivation

No need for a separate token, better retries. Clearer Pipeline UI.

Thanks to @BaptisteLalanne for all the support!

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@iliakur iliakur marked this pull request as ready for review January 8, 2025 14:49
@iliakur iliakur requested a review from a team as a code owner January 8, 2025 14:49
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (f3966d5) to head (fe9cdd8).
Report is 13 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

BaptisteLalanne
BaptisteLalanne previously approved these changes Jan 8, 2025
Copy link
Collaborator

@BaptisteLalanne BaptisteLalanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise:
Truly lovely to see all those polling scripts removed !

LGTM on GitLab pipeline definition 💯
Small question on the manually triggered pipeline in case you want to always have it

.gitlab/build_agent.yaml Show resolved Hide resolved
Copy link
Collaborator

@BaptisteLalanne BaptisteLalanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nubtron
nubtron previously approved these changes Jan 10, 2025
@iliakur iliakur added this pull request to the merge queue Jan 10, 2025
@iliakur iliakur removed this pull request from the merge queue due to a manual request Jan 10, 2025
@iliakur iliakur added this pull request to the merge queue Jan 11, 2025
Merged via the queue into master with commit edf5718 Jan 11, 2025
37 checks passed
@iliakur iliakur deleted the ik/AI-4524/fix-agent-build-trigger branch January 11, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants