Don't skip last index during iteration.

[voyvodov]

Last empty element is removed on line 358 in get_info func

What does this PR do?

Fixing #18995

Motivation

We're missing information for the last index in every namespace

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
• If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (c370c7b) to head (14b2d11).
Report is 88 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
activemq	?
aerospike	88.81% <100.00%> (+1.79%)	⬆️
cassandra	?
hive	?
hivemq	?
hudi	?
ignite	?
jboss_wildfly	?
kafka	?
presto	?
solr	?

Flags with carried forward coverage won't be shown. Click here to find out more.

[iliakur]

@voyvodov thanks for your contribution!

Could you please add a unit test for it? lmk if I can help with that.

[voyvodov]

@voyvodov thanks for your contribution!

Could you please add a unit test for it? lmk if I can help with that.

Thanks @iliakur ! If you can help with the unit tests that will be great.

I'm trying to at least add indexes to the e2e tests, but if we can do it in unit too, that will be great.
I've some draft unit tests, but that requires to move sindex metrics collection in separate func, e.g.

def collect_sindex(self, namespaces, namespace_tags):
    for ns in namespaces:
         # https://www.aerospike.com/docs/reference/info/#sindex
        sindex = self.get_info('sindex/{}'.format(ns))
        for idx in parse_namespace(sindex, ns, 'indexname'):
            sindex_tags = ['sindex:{}'.format(idx)]
            sindex_tags.extend(namespace_tags)
            self.collect_info('sindex/{}/{}'.format(ns, idx), SINDEX_METRIC_TYPE, tags=sindex_tags)

[voyvodov]

@iliakur I think I found a way to do it correctly, without touching base code.

Can you check?

[iliakur]

Thanks for this!

Left a few suggestions to clean things up, otherwise lgtm!!

[voyvodov]

Thanks for this!

Left a few suggestions to clean things up, otherwise lgtm!!

Oh my....Didn't notice that I commit all the "debug" prints there 🤦🏽 .

Sorry, all fixed.

[iliakur]

sorry about the delay!