Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDS: Update README #18801

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

DDS: Update README #18801

wants to merge 33 commits into from
+14 −3

Conversation

tirthrajchaudhari-crest
Copy link
Contributor

What does this PR do?

  • Updated the configurations section in README

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

tirthrajchaudhari-crest and others added 27 commits August 6, 2024 15:16
@tirthrajchaudhari-crest
Add trend micro vision one xdr assets
7053b1e
@tirthrajchaudhari-crest
Add images and update readme
71c1c92
@tirthrajchaudhari-crest
Add integration in labeler.yaml file
ddd1938
@tirthrajchaudhari-crest
Update pipeline yaml
e2eb2c8
@tirthrajchaudhari-crest
Add service in test yaml file
951398e
@tirthrajchaudhari-crest
Update sample in test yaml file
f40499a
@tirthrajchaudhari-crest
Update test yaml sample
e072c39
@tirthrajchaudhari-crest
Update test results
947dfe2
@tirthrajchaudhari-crest
Update dashboards
d140ea0
@tirthrajchaudhari-crest
Minor README change
261976c
@tirthrajchaudhari-crest
Address review comments
6d80ffe
@tirthrajchaudhari-crest
Resolve merge conflicts
fa7cf83
@tirthrajchaudhari-crest
Update manifest file
0378ff2
@thibaultkrebs
Merge branch 'master' into trend-micro-vision-one-xdr-assets-v1.0.0
0a9aa60
@tirthrajchaudhari-crest
Resolve merge conflicts
bfbadaf
@tirthrajchaudhari-crest
Merge branch 'master' of https://github.com/DataDog/integrations-core …
2fe687f 
…into trend-micro-vision-one-xdr-assets-v1.0.0
@tirthrajchaudhari-crest
Merge branch 'trend-micro-vision-one-xdr-assets-v1.0.0' of https://gi…
db4aef1 
…thub.com/bhargavnariyanicrest/integrations-core into trend-micro-vision-one-xdr-assets-v1.0.0
@tirthrajchaudhari-crest
Revert app_uuid to it's original value in manifest
fa87545
@tirthrajchaudhari-crest
Update display_on_public_website to false in manifest
f6dd080
@tirthrajchaudhari-crest
Address review comments
a09dd09
@tirthrajchaudhari-crest
Address review comments
e047aec
@tirthrajchaudhari-crest
Remove traliling space in README
42fa694
@tirthrajchaudhari-crest
Address review comments
a2abec0
@tirthrajchaudhari-crest
Resolve merge conflicts
d4aed6d
@tirthrajchaudhari-crest
Update README
964360d
@tirthrajchaudhari-crest
Update readme
b8aa2ae
@tirthrajchaudhari-crest
Update configurations section of readme
4c3a574
@tirthrajchaudhari-crest tirthrajchaudhari-crest changed the title DDS: Update REAME DDS: Update README Oct 9, 2024
brett0000FF
brett0000FF previously approved these changes Oct 9, 2024
View reviewed changes
@torosmassa
Copy link

@tirthrajchaudhari-crest does this still need to be merged given all the updates were bundled as part of #19280?

@tirthrajchaudhari-crest
Copy link
Contributor Author

given all the updates were bundled as part of

Yes @torosmassa, We have raised the README update PR for Trend Micro Vision One XDR integration separately before the common README update PR was raised. Therefore, this should be merged separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brett0000FF brett0000FF brett0000FF left review comments

@jnhunsberger jnhunsberger Awaiting requested review from jnhunsberger

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog/no-changelog docs/review-requested documentation ecosystems/review-requested integration/trend_micro_vision_one_xdr product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/documentation team/logs-backend team/saas-integrations team/siem-logs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tirthrajchaudhari-crest @torosmassa @brett0000FF @thibaultkrebs @shubhamvekariya-crest