Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ecs explorer doc #27023

Merged
merged 3 commits into from
Jan 10, 2025
Merged

update ecs explorer doc #27023

merged 3 commits into from
Jan 10, 2025

Conversation

kangyili
Copy link
Contributor

@kangyili kangyili commented Jan 8, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Preview links (active after the build_preview check completes)

Modified Files

@kangyili kangyili force-pushed the kangyi/update-ecs-doc branch from ede1b4a to 3446a66 Compare January 8, 2025 15:18
@kangyili kangyili marked this pull request as ready for review January 9, 2025 17:23
@kangyili kangyili requested a review from a team as a code owner January 9, 2025 17:23
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one minor suggestion

@michaelcretzman
Copy link
Contributor

michaelcretzman commented Jan 9, 2025

@kangyili

Approved with one minor grammar suggestion.
You can merge your PR by adding a comment containing just the command /merge.
The PR will go into the merge queue automatically once it's approved.
FYI - if the PR isn't approved within 2 hours after you add the /merge command you need to add the /merge command again.

@kangyili
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 10, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-10 09:39:46 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-10 09:47:36 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit e5dd2df into master Jan 10, 2025
14 of 16 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kangyi/update-ecs-doc branch January 10, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants