Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rollup guide #27008
base: master
Are you sure you want to change the base?
Add rollup guide #27008
Changes from 1 commit
f956be0
fa76c26
5e74d7e
a41dbce
b0ca067
9da42b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few terms here like "scalar value" and "direct query" that I'm not familiar with, so I'm not 100% I understand this example. I wonder if we could make it sound a little more like the previous example? Maybe something like:
Reading it again, I think I'm confused because both of these numbers are over an hour-long period, so I'm not sure where the daily rollup part comes in 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section feels pretty vague and not particularly helpful to me, but I'm not sure how I would improve it.
I'm also not the target audience for this, so I'll trust your judgment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2¢ is that this section feels more theoretical than you would expect after reading a heading like "solutions and best practices."
I'm wondering if we could remove it altogether, since I think all three of these points are already covered earlier in the topic. Otherwise, maybe we could introduce some more examples here with some specific calculations for readers to follow along with, so the advice feels more actionable. If you do the latter, I might incorporate it into the above sections because I think it could aid the conceptual understanding - I don't think I'd collect it at the end, in case readers don't scroll that far 🙂
This one is tough to get right! It's necessarily way into the weeds because it's a counterintuitive nuance that users very understandably struggle with, and that's super difficult to explain away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yea, that makes sense. It seems like a repeat of what was already covered so I'll remove.