Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification on monitor attributes and tags #26892

Merged

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Dec 23, 2024

What does this PR do? What is the motivation?

  • Clarify attribute and tag variables in monitor messages
  • General formatting to move some content in collapse blocks
  • DOCS-8882

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@estherk15 estherk15 requested a review from a team as a code owner December 23, 2024 20:07
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just have a couple of small suggestions.

content/en/monitors/notify/variables.md Outdated Show resolved Hide resolved
content/en/monitors/notify/variables.md Outdated Show resolved Hide resolved
content/en/monitors/notify/variables.md Outdated Show resolved Hide resolved
Co-authored-by: DeForest Richards <[email protected]>
@estherk15 estherk15 requested a review from drichards-87 January 6, 2025 16:01
@estherk15
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-06 18:06:29 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-06 18:13:16 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 10c2e6a into master Jan 6, 2025
18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the esther/docs-8882-clarify-attribute-tag-variables branch January 6, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants