Fix exception property offset computation for PHP 8.1+ #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're shared across all inheritors on PHP 8.1+ and thus only need to be incremented on the specific ce. This issue arises when a property from an inherited internal class extending Exception is itself inherited by another class. Also fix an accidentally discovered use-after-free with peer.service. Fixes #2898. Signed-off-by: Bob Weinand <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2901 +/- ##
=========================================
Coverage 78.21% 78.21%
Complexity 2526 2526
=========================================
Files 173 173
Lines 18749 18749
Branches 988 988
=========================================
Hits 14664 14664
Misses 3544 3544
Partials 541 541
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Benchmarks [ tracer ]Benchmark execution time: 2024-10-17 13:26:16 Comparing candidate commit 72ff094 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics. scenario:TraceFlushBench/benchFlushTrace
|
iamluc
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're shared across all inheritors on PHP 8.1+ and thus only need to be incremented on the specific ce.
This issue arises when a property from an inherited internal class extending Exception is itself inherited by another class.
Also fix an accidentally discovered use-after-free with peer.service.
Fixes #2898.